Vendor new-relic-deploy via Composer (to address Snyk alerts) - #280
Open
banoodle wants to merge 6 commits into
Open
Vendor new-relic-deploy via Composer (to address Snyk alerts)#280banoodle wants to merge 6 commits into
banoodle wants to merge 6 commits into
Conversation
Require pantheon-quicksilver/new-relic-deploy as an inline package (upstream pins composer/installers ~1.0, conflicting with ^2). Add the quicksilver-script installer type, point the sync_code and deploy workflows at the vendored script, and remove the two checked-in copies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pantheon-quicksilver/new-relic-deploy package is functionally stale (deprecated binding API key + New Relic REST v2 deploy markers). Swap it for Pantheon's current quicksilver-examples script (NerdGraph changeTrackingCreateDeployment + pantheon_get_secret), defined inline as a quicksilver-script pinned to commit ebc53ff. Repoint both pantheon.yml hooks at the new path. NOTE: requires a Pantheon secret named new_relic_api_key (New Relic User API key) or the script bails with no metadata. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The vendored New Relic deploy script reads the API key from a Pantheon secret (new_relic_api_key). Add a one-time, per-site initialization step to the README documenting the terminus secret:site:set command and the required New Relic User key, scope, and type, per Pantheon's docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
banoodle
marked this pull request as ready for review
June 5, 2026 22:51
sean-e-dietrich
requested changes
Jun 15, 2026
sean-e-dietrich
left a comment
sean-e-dietrich
left a comment
Contributor
There was a problem hiding this comment.
for some reason i thought we would only have that 1 part, unfortunately this will add everything from the repo into the project, at this point it might be better to update the project with what they have in the examples repo
banoodle
changed the title
Contributor
Author
|
OK @sean-e-dietrich - I removed it from composer management and just added the single script to the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Via a support ticket, Pantheon support told me the version of the new_relic_deploy script here...
https://github.com/pantheon-quicksilver/new-relic-deploy...is a stale copy, and the current working version of the script is here:
https://github.com/pantheon-systems/quicksilver-examples/blob/main/new_relic_deploy/new_relic_deploy.phpI wish Pantheon would issue a 2.0 release of pantheon-quicksilver/new-relic-deploy. I suggested it in the ticket, but I doubt they will listen to me ; )
Summary
Addresses #279 - Our version of the new_relic_deploy quicksilver script throws Snyk vulnerability alerts and doesn't work with the current New Relic API.
pantheon-systems/quicksilver-examplespackage, managed via Composer.Note
This will need to be done for a lot of our projects. I have done it for Humane World on pending PR-624, and validated that it works:
🤖 Generated with Claude Code