Batching retrieval of JGP Frictionless descriptor data#206
Merged
jeff-cohere merged 6 commits intomainfrom Apr 9, 2026
Merged
Conversation
…lts. Also, some more guards for duplicate file IDs in endpoints.
jeff-cohere
added
the
JDP
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 62.34% 62.40% +0.06%
==========================================
Files 34 34
Lines 4517 4533 +16
==========================================
+ Hits 2816 2829 +13
- Misses 1389 1391 +2
- Partials 312 313 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattldawson
approved these changes
Apr 9, 2026
Collaborator
mattldawson
left a comment
mattldawson
left a comment
There was a problem hiding this comment.
looks good! one very minor suggestion to take or leave
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unofficial backend we use to get descriptor data from the JGI Data Portal silently truncates requests at around 50 files, so we now batch them. See comments in
databases/jdp/database.go.