fix: remove invalid bullet format from ReactQuill configs#6585
Open
SueJianjian wants to merge 2 commits into
Open
fix: remove invalid bullet format from ReactQuill configs#6585SueJianjian wants to merge 2 commits into
SueJianjian wants to merge 2 commits into
Conversation
Member
|
hey @SueJianjian , may you link the ticket? |
Author
|
Linked the PR to #6581 in the description now. Thanks for flagging it. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6581
bulletentry from the Quillformatsarrayslistin place, which already covers ordered and bullet listsWhy
Quill expects
listin theformatsarray, whilebulletis only used as a toolbar value such as{ list: "bullet" }.Having
bulletinsideformatscauses the console error:Cannot register bullet specified in formats configChange
keep-ui/features/alerts/alert-note/ui/alert-note-modal.tsxkeep-ui/features/incidents/create-or-update-incident/ui/create-or-update-incident-form.tsxValidation
bulletentry informatsbulletand left the existing toolbar config unchangedNotes