Skip to content

Complete cross-platform native dependencies - #93

Merged
rgarcia merged 2 commits into
mainfrom
hypeship/complete-native-lockfile
Aug 21, 2026
Merged

Complete cross-platform native dependencies#93
rgarcia merged 2 commits into
mainfrom
hypeship/complete-native-lockfile

Conversation

@rgarcia

@rgarcia rgarcia commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add every platform-specific Rolldown, Rollup, Sharp, and clipboard package to the lockfile at the existing exact dependency versions
  • add a dependency-resolution-aware lockfile validator so Linux CI catches omitted native packages for other platforms
  • run the validator before installs in CI and the Browser Loop release workflow

This fixes clean installs that passed on Linux but omitted the native bindings required to build on macOS ARM64.

Verification

  • npx npm@11.17.0 ci --ignore-scripts --os=darwin --cpu=arm64 installs the expected macOS ARM64 Rolldown, Rollup, and Sharp packages
  • negative validator check catches a deliberately removed @rolldown/binding-darwin-arm64 entry
  • npx npm@11.17.0 ci
  • npm run build --workspace @onkernel/browser-loop
  • npm run typecheck --workspace @onkernel/browser-loop
  • npm test --workspace @onkernel/browser-loop — 34 files, 429 tests

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b234fc3. Configure here.

Comment thread package-lock.json
Comment thread package-lock.json
@rgarcia
rgarcia merged commit 2a2009c into main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant