Repository navigation
Conversation
yummybomb
force-pushed
the
hypeship/gpu-large-memory-flag
branch
2 times, most recently
from
October 6, 2026 21:18
80f2e46 to
863eae4
Compare
yummybomb
force-pushed
the
hypeship/gpu-large-memory-flag
branch
from
October 6, 2026 22:00
863eae4 to
854d9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel browsers create --gpu --memory 12GiBrequests the large GPU browser tier (8 vCPU, 12 GiB memory, 4 GiB VRAM).browsers create --memorynow accepts12GiBalongside8GiBand16GiB, and the flag help says which values apply to CPU and GPU browsers.browser-pools createandbrowser-pools updatekeep their own allowlist of8GiBand16GiB, since pools never run GPU browsers.--memory 12GiBon a pool now fails locally withinvalid --memory value: 12GiB (must be one of 8GiB, 16GiB), matching the pool flag help.For
browsers create, the CLI only checks that the value is in the list. The API enforces the combination:12GiBrequires--gpu, and8GiB/16GiBare CPU-only. Otherwise it returns a 400 with the reason, the same way--memory 16GiB --gpuis handled today.The README's
browsers createflag list now documents--gpuand--memory, which it did not list before.Notes
memory=12GiBfor GPU browsers. The Go SDK'sBrowserMemoryRequestis a string type, so no SDK bump is needed to send the new value.Testing
go test ./...passes. NewTestBrowserPoolsMemoryRejectsGPUTiercovers pool create and update;TestBrowsersCreate_WithMemorycovers12GiBwith--gpu.golangci-lintwas not run (not installed locally).