fix(apiquery): encode float32 query values at float32 precision - #172
Open
latent-9 wants to merge 1 commit into
Open
fix(apiquery): encode float32 query values at float32 precision#172latent-9 wants to merge 1 commit into
latent-9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/apiquery/encoder.goformats bothreflect.Float32andreflect.Float64values withstrconv.FormatFloat(..., 64), so float32 query parameters are serialized with float64 noise, e.g.43.76becomes43.7599983215332. The siblinginternal/apiform/encoder.goalready splits the two kinds; this makes apiquery match. Query tests pinned to the noisy output are updated to the exact value.Note
Low Risk
Localized serialization fix in apiquery encoding with test-only expectation updates; float64 behavior is unchanged.
Overview
float32 query parameters are now serialized with 32-bit
strconv.FormatFloatinstead of sharing the float64 path, so values like43.76no longer appear as43.7599983215332in encoded query strings.This mirrors the existing split in
internal/apiform/encoder.go. Encoder tests that pinned the old noisye=output are updated to expect the rounded float32 representation.Reviewed by Cursor Bugbot for commit 98a09ce. Bugbot is set up for automated code reviews on this repo. Configure here.