Skip to content

Show a notice when a field value was rejected - #21

Open
masnwilliams wants to merge 2 commits into
mainfrom
hypeship/replace-existing-field-notice
Open

Show a notice when a field value was rejected#21
masnwilliams wants to merge 2 commits into
mainfrom
hypeship/replace-existing-field-notice

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

summary

  • require canonical managed-auth fields to declare reason: "missing" | "rejected"
  • carry the reason through the canonical-to-rendered field projection
  • show a localized rejection notice only when reason === "rejected"
  • retain legacy-only placeholder and hint text while canonical and legacy projections coexist
  • expose fieldRejectedNotice and inputRejectedNotice customization points
  • validate the vendored canonical field, choice, event, and submit types against @onkernel/sdk@0.93.0
  • install the latest Kernel SDK in the backend quick start

This removes the temporary public replace_existing shape entirely.

stack

testing

  • bun run test
  • bun run typecheck
  • bun run build
  • bun run format:check
  • cd packages/managed-auth-react && npm pack --dry-run
  • linked the top-of-stack package into managed-auth-hosted-ui
  • hosted UI: bun run test, bun run typecheck, bun run lint, bun run build, bun run format:check

Note

Medium Risk
Touches managed-auth protocol types and the login form’s field projection. Behavior is additive UI plus a required reason on canonical fields, not auth/session security logic.

Overview
Canonical managed-auth fields now require reason: "missing" | "rejected". When a field is rejected, the form shows a localized notice so users know to enter a new value.

fieldsFromCanonical carries reason into the rendered field and still pulls placeholder/hint from coexisting legacy discovered_fields. Customization is via fieldRejectedNotice and the inputRejectedNotice appearance slot (danger-colored).

Vendored protocol types are checked against @onkernel/sdk@0.93.0, and the README install line includes the SDK.

Reviewed by Cursor Bugbot for commit bd66c28. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
managed-auth-react-demo Ready Ready Preview Aug 20, 2026 8:27pm

@masnwilliams
masnwilliams marked this pull request as ready for review August 2, 2026 18:41
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from 7ab0711 to 0a99efa Compare August 5, 2026 23:12
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from 0a99efa to bc63cd6 Compare August 5, 2026 23:31
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from bc63cd6 to 32fd50b Compare August 5, 2026 23:44
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from 32fd50b to 334f881 Compare August 14, 2026 17:03
@masnwilliams masnwilliams changed the title Show a notice when a saved field value was rejected Show a notice when a field value was rejected Aug 14, 2026
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from 334f881 to 88003e5 Compare August 20, 2026 20:06
@masnwilliams
masnwilliams requested a review from akxue August 20, 2026 20:11
Base automatically changed from hypeship/canonical-awaiting-input to main August 20, 2026 20:12
@masnwilliams
masnwilliams force-pushed the hypeship/replace-existing-field-notice branch from 88003e5 to 1ceef72 Compare August 20, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant