kbuild: upload make backend dtbs from an archive - #3186
Open
nuclearcat wants to merge 1 commit into
Open
Conversation
Archive uploads of dtbs are only used when both the extracted dtb files and a dtbs.tar.xz artifact are present. The tuxmake backend gets the archive for free, but _package_dtbs() only ever copies the dtbs_install output into the artifacts directory, so make backend builds upload every dtb as a separate request. That is 36 of the currently scheduled kbuild jobs, including the whole CIP set and the arm64 chromebook build. Pack the installed dtbs into dtbs.tar.xz with the same dtbs/ prefix inside as the tuxmake archive, so upload_artifacts() picks it up with no change. The archive is only created when at least one dtb was built, which leaves verify_build() to drop the artifact and the upload to fall back to individual files otherwise. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archive uploads of dtbs are only used when both the extracted dtb files and a dtbs.tar.xz artifact are present. The tuxmake backend gets the archive for free, but _package_dtbs() only ever copies the dtbs_install output into the artifacts directory, so make backend builds upload every dtb as a separate request. That is 36 of the currently scheduled kbuild jobs, including the whole CIP set and the arm64 chromebook build.
Pack the installed dtbs into dtbs.tar.xz with the same dtbs/ prefix inside as the tuxmake archive, so upload_artifacts() picks it up with no change. The archive is only created when at least one dtb was built, which leaves verify_build() to drop the artifact and the upload to fall back to individual files otherwise.