Added searchSettings to TwoDeepEntityPage and ResponsesController#1021
Added searchSettings to TwoDeepEntityPage and ResponsesController#1021
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughTwoDeepEntityPage gained an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@backend/src/main/kotlin/hu/bme/sch/cmsch/controller/admin/TwoDeepEntityPage.kt`:
- Around line 65-67: TwoDeepEntityPage's constructor accepts searchSettings but
the two view handlers do not add it to the model before rendering overview4, so
templates never receive the setting; update both view handler implementations
inside TwoDeepEntityPage to put the searchSettings into the model (use the same
model key / pattern used in OneDeepEntityPage where overview4 is rendered) when
searchSettings != null, ensuring the model passed to render("overview4", model)
includes the search configuration; reference TwoDeepEntityPage, the view
handlers that call render("overview4", ...) and the constructor parameter
searchSettings to locate where to add the model entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 458b43aa-32fb-4eb4-9a6c-3dfdd847571d
📒 Files selected for processing (2)
backend/src/main/kotlin/hu/bme/sch/cmsch/component/form/ResponsesController.ktbackend/src/main/kotlin/hu/bme/sch/cmsch/controller/admin/TwoDeepEntityPage.kt
backend/src/main/kotlin/hu/bme/sch/cmsch/controller/admin/TwoDeepEntityPage.kt
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by CodeRabbit
New Features
Refactor