Repository navigation
Order akp-crd-manager, opscenter-features and kube-ui-server on spokes - #71
Merged
Merged
Conversation
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings spoke opscenter-core ordering in line with the hub (
ace-installer):akp-crd-manager→opscenter-features→kube-ui-server.akp-crd-manager, the spokeopscenter-featuresHelmRelease getsdependsOn: akp-crd-manager, so the missing third-party CRDs exist before opscenter-features installs.kube-ui-servergetsdependsOn: opscenter-features.updateHelmReleaseDependencyignores Featurerequirementsfor opscenter-core and stripsdependsOnwhen there are none, so this is set explicitly. Without it, kube-ui-server can install before the CRDs exist and its Capabilities-gated ServiceMonitor gets skipped.akp-crd-manageritself is rendered by the opscenter-core FeatureSet editor like the other core features.Related: appscode-cloud/installer#1361, appscode-cloud/ui-wizards#1193, appscode-cloud/b3#1682.