Repository navigation
Derive the contrast canvas colour from color-scheme and flag ancestor background images - #472
Merged
koddsson merged 7 commits intoSep 17, 2026
Conversation
… background images getEffectiveBackgroundColor returned opaque white whenever no ancestor had a background-color, which is wrong for pages using color-scheme: dark and for content inside shadow roots. The walk now continues out of shadow roots through the host, flattens translucent layers in order, and falls back to a canvas colour derived from the root element's computed color-scheme. A background-image on any ancestor, not just the element itself, now marks a failing result as needsReview. The error payload also carries backgroundSource, the element whose background-color was used (null for the canvas), so reports can be verified without reproducing the page. Closes #468 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…into fix/468-contrast-canvas-colour
koddsson
marked this pull request as ready for review
September 17, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.