Remove dead GitHub skills modal from /explore - #1897
Open
ionfwsrijan wants to merge 1 commit into
Open
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Fetch Skills" button in the GitHub-skills modal on /explore (explore.html:668) has no JavaScript handler anywhere — script.js only binds #btn-show-github, which does not exist on /explore. The modal markup exists at explore.html:646-672 with no trigger to open it, so it is completely dead UI on a public page.
Fix
Remove the dead GitHub modal block (overlay, username input, error div, Fetch Skills and Cancel buttons) from explore.html. The GitHub skill-import feature remains fully available on the homepage (index.html), which is the only page where it is actually wired up (trigger + OAuth flow + addSkill). The script.js modal-binding and OAuth-callback code already guards against missing elements, so no JS changes are needed.
Files changed
Testing
Closes #1858