Handle malformed progress in learning-path analytics - #1901
Open
ionfwsrijan wants to merge 1 commit into
Open
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /api/learning-path/<path_id>/analytics returns HTTP 500 when stored progress contains a malformed value. create_path/update_path accept arbitrary client JSON, so a non-dict progress value (e.g. a string or list) makes stats.get(...) raise AttributeError, which the except (ValueError, TypeError) clause does not catch. A non-dict progress container also breaks progress.items().
Fix
In src/routes/main_routes.py analytics handler:
Files changed
Testing
Closes #1861