fix: remove duplicate scroll-top-btn on project page (issue #1878) - #1912
Open
ionfwsrijan wants to merge 1 commit into
Open
fix: remove duplicate scroll-top-btn on project page (issue #1878)#1912ionfwsrijan wants to merge 1 commit into
ionfwsrijan wants to merge 1 commit into
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
project.htmlrendered two buttons withid="scroll-top-btn"— an inline↑button followed by thepartials/scroll_top_btn.htmlinclude that defines the same ID. Duplicate IDs are invalid HTML, anddocument.getElementById("scroll-top-btn")instatic/script.jsresolves only to the first element, leaving the partial's button (and its expected behavior) inert.Fix
↑button fromproject.htmland rely on the sharedpartials/scroll_top_btn.htmlinclude — the same patternexplore.htmluses.tests/test_html_template_duplicate_ids.py— a pure-file CI sanity check that scans every template (including partials) and fails if any element ID is defined more than once, preventing duplicate-ID regressions.Files changed
src/templates/project.html— dropped the duplicate inline scroll button.tests/test_html_template_duplicate_ids.py— new duplicate-ID check acrosssrc/templates/**/*.html.Testing
tests/test_html_template_duplicate_ids.py— 1 passed (run with--noconftestsince the app can't boot locally due to the pre-existing App fails to boot: NameError: name 're' is not defined in portfolio_analyzer.py #1810).document.getElementById("scroll-top-btn")instatic/script.jsnow targets the single button from the partial.Closes #1878