fix: honor MAX_RESULTS default cap in recommendations (issue #1881) - #1915
Open
ionfwsrijan wants to merge 1 commit into
Open
fix: honor MAX_RESULTS default cap in recommendations (issue #1881)#1915ionfwsrijan wants to merge 1 commit into
ionfwsrijan wants to merge 1 commit into
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MAX_RESULTS = 3inrecommender.pywas dead code.get_recommendationsonly capped results whenmax_resultswas non-None, and the route always passedmax_results=None, so the recommendation API returned every relevant project (28–30 on a broad "python" query) — an unbounded payload far beyond what the UI uses.Fix
src/utils/recommender.py:get_recommendationsnow honorsMAX_RESULTSas the default cap —scored_projects[:MAX_RESULTS]whenmax_results is None, with explicitmax_resultsstill able to override.tests/test_basic.py: addedtest_get_recommendations_default_cap_applies, asserting a broad query returns ≤ 3 by default while an explicitmax_results=100returns more.Files changed
src/utils/recommender.py— the default result cap now takes effect.tests/test_basic.py— new regression test for the default cap.Testing
test_get_recommendations_max_threeand all other recommender tests (test_tiebreaker,test_case_sensitivity, determinism/format checks) remain satisfied. Full suite runs in CI (local app boot is blocked by the pre-existing App fails to boot: NameError: name 're' is not defined in portfolio_analyzer.py #1810).Closes #1881