Refactor: Use More Descriptive, Expressive Naming Across Frontend #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello @Hijanhv , please try to stay in one PR and set a proper PR title. CC @LogicalGuy77 |
Hijanhv
changed the title
Contributor
|
Please rebase (not merge, never ever merge) to master to fix the conflict. |
Contributor
Author
ok |
- Rename currNamespace → currentNamespace - Rename nsSub → namespaceSubscription - Rename pollSub → pollingSubscription - Rename svc → inferenceService throughout codebase - Rename svcPrv → inferenceServicePrivate - Rename config → dialogConfig/snackConfig (context-specific) - Rename res → dialogResponse - Rename currLogs → currentLogs Updated 13 files including TypeScript components, HTML templates, and test specs to use more expressive and pronounceable variable names while maintaining all functionality. Signed-off-by: Hijanhv <[email protected]>
Signed-off-by: Hijanhv <[email protected]>
Signed-off-by: Hijanhv <[email protected]>
Signed-off-by: Hijanhv <[email protected]>
- Replace test() with it() in utils.jest.spec.ts for Karma/Jasmine compatibility - Remove Jest-specific beforeEach code (jest.clearAllMocks) - Update package-lock.json with kubeflow dependency setup - All 57 tests now pass successfully Signed-off-by: Hijanhv <[email protected]>
Hijanhv
force-pushed
the
feature/my-changes
branch
from
039af10 to
846b828
Compare
Contributor
|
all checks are passing, good work @Hijanhv , let me test it once locally otherwise it looks good to merge |
Contributor
Author
|
Thanks a lot @LogicalGuy77 . Could never do this without your guidance and support while I made all mess . :) now no mess ever , only awareness and professionalism. |
| ActionIconValue, | ||
| DateTimeValue, | ||
| DialogConfig, | ||
| DialogConfig as DialogConfiguration, |
Contributor
There was a problem hiding this comment.
doesn't make sense introducing extra variable as alias, keep it as DialogConfig
Contributor
|
I've tested it looks good, just make that one change then good to merge! @Hijanhv |
Signed-off-by: Hijanhv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #144 — Summary
Refactored frontend TypeScript and Angular templates to use clearer, more descriptive identifier names across components, services, and tests.
Key Changes
Variables & Services
svc→inferenceServicesvcPrv→inferenceServicePrivatecurrentNamespace,currentLogsUI Configuration Objects
dialogConfig→dialogConfigurationsnackConfig→snackConfigurationSubscriptions
namespaceSubscriptionpollingSubscriptionCallbacks & HTML Bindings
dialogResponseinstead ofres@Inputproperties to match new namesCode Quality
Impact
Improved code readability and maintainability with no functional changes.
All TypeScript files, HTML templates, and unit tests were updated consistently.