Repository navigation
chore: pin mysql-operator source refs to the v0.8.0 tag - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Five Dockerfiles pulled mysql-operator sources from the floating
extra_imagebranch head, so the binaries baked into an image were not traceable to a commit and builds were not reproducible.extra_imageis also being retired as the mysql-operator trunk (moving tomain, withmasterrestored as the upstream mirror — see ksmartdata/mysql-operator#21).Per this repo's own policy (
scripts/check-dockerfile-source.sh: no code pulls from branch heads), the refs are pinned to the v0.8.0 tag instead of being renamed to the new branch.check-dockerfile-source.shpasses on all Dockerfiles after this change.What
mysql-operator-sidecar-5.7/mysql-operator-sidecar-8.0/mysql-operator-sidecar-8.0/Dockerfile.base: introduceARG OPERATOR_REF=v0.8.0and downloadarchive/${OPERATOR_REF}.zip(works with tags, branches, and commits; the unzip dir is normalized with a wildcardmv)mysql-operator-sidecar-8.4:ARG OPERATOR_REFdefaultextra_image→v0.8.0(both stages)mgr-operator:ARG MYSQL_OPERATOR_EXTRA_IMAGE_REFdefaultextra_image→v0.8.0(ARG name kept for dispatch compatibility)Releasing a new operator version is now: tag mysql-operator → bump the default here (or pass
build-argsat dispatch).The PR CI rebuild of the changed image directories is expected.