Skip to content

refactor: logging and prompting#85

Open
xcoulon wants to merge 2 commits intomasterfrom
logger
Open

refactor: logging and prompting#85
xcoulon wants to merge 2 commits intomasterfrom
logger

Conversation

@xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Oct 11, 2024

using https://github.com/charmbracelet/log and https://github.com/charmbracelet/huh
also, reword a few messages output in the console

Signed-off-by: Xavier Coulon xcoulon@redhat.com

using github.com/charmbracelet/log and github.com/charmbracelet/huh
also, reword a few messages output in the console

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 60.42781% with 148 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (8d63298) to head (e6d00c3).

Files with missing lines Patch % Lines
pkg/ioutils/terminal.go 0.00% 69 Missing ⚠️
pkg/cmd/adm/restart.go 61.53% 6 Missing and 4 partials ⚠️
pkg/client/client.go 62.50% 7 Missing and 2 partials ⚠️
pkg/cmd/adm/install_operator.go 75.00% 2 Missing and 7 partials ⚠️
pkg/cmd/adm/must_gather_namespace.go 53.33% 6 Missing and 1 partial ⚠️
pkg/cmd/retarget.go 61.53% 3 Missing and 2 partials ⚠️
pkg/cmd/ban.go 71.42% 2 Missing and 2 partials ⚠️
pkg/configuration/configuration.go 60.00% 4 Missing ⚠️
pkg/cmd/adm/register_member.go 90.00% 2 Missing and 1 partial ⚠️
pkg/cmd/add_space_users.go 77.77% 1 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   68.00%   65.75%   -2.25%     
==========================================
  Files          44       44              
  Lines        3175     3119      -56     
==========================================
- Hits         2159     2051     -108     
- Misses        825      878      +53     
+ Partials      191      190       -1     
Files with missing lines Coverage Δ
pkg/cmd/base_kubectl.go 87.75% <100.00%> (ø)
pkg/cmd/generate/cluster.go 76.31% <100.00%> (-0.61%) ⬇️
pkg/context/command_context.go 0.00% <ø> (-54.55%) ⬇️
pkg/cmd/generate/admin-manifests.go 47.67% <66.66%> (ø)
pkg/cmd/generate/cli_configs.go 73.62% <91.66%> (ø)
pkg/cmd/generate/nstemplatetiers.go 53.03% <75.00%> (-0.71%) ⬇️
pkg/cmd/status.go 79.48% <80.00%> (ø)
pkg/cmd/add_space_users.go 72.72% <77.77%> (-0.70%) ⬇️
pkg/cmd/adm/unregister_member.go 55.55% <80.00%> (+1.01%) ⬆️
pkg/cmd/approve.go 69.89% <71.42%> (ø)
... and 18 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants