add more tests but they need the signature feature#793
Open
entlein wants to merge 22 commits into
Open
Conversation
Implement generic signing and verification framework for ApplicationProfiles and SeccompProfiles using ECDSA P-256 signatures compatible with cosign. Key features: - SignableProfile interface for extensible profile type support - Keyless signing support using OIDC identity providers - Key-based signing for offline/air-gapped environments - Signature storage in profile metadata.annotations - CLI tool (sign-profile) for signing and verifying profiles - Automatic verification in ApplicationProfileCache on profile load Core implementation: - pkg/signature/ package with ECDSA P-256 signing/verification - Profile adapters for ApplicationProfile and SeccompProfile - EnableProfileVerification config flag (default: false) - On verification failure: skip profile with warning (don't crash) Files: - pkg/signature/annotations.go, interface.go, sign.go, verify.go - pkg/signature/cosign_adapter.go, signer.go, verifier.go - pkg/signature/profiles/applicationprofile_adapter.go - pkg/signature/profiles/seccompprofile_adapter.go - cmd/sign-profile/main.go - pkg/config/config.go - add EnableProfileVerification flag - pkg/objectcache/applicationprofilecache/ - integrate verification at load time - docs/signing/README.md - comprehensive documentation Tests: - 15 signature package tests covering signing, verification, tampering detection - 5 adapter tests for ApplicationProfile and SeccompProfile adapters - All tests passing Co-authored-by: Cerebras Agent <193945191+isaact-cerebras@users.noreply.github.com> Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com> Co-authored-by: Cerebras Agent <193945191+isaact-cerebras@users.noreply.github.com> Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
- Implement RulesAdapter implementing SignableProfile interface - Add signature verification in RulesWatcher when enabled - Pass config to RulesWatcher to enable profile verification toggle - Add comprehensive tests for rules signing and verification - Track skipped rules due to verification failures in logs - Maintain consistent behavior with application and seccomp profiles Co-authored-by: Cerebras Agent <193945191+isaact-cerebras@users.noreply.github.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…y need the nodeagent/sign-ap PR and the storage PR to run Signed-off-by: entlein <einentlein@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Tests for signed APs assuming the new storage is used
put an [x] in the box to get it checked
Only contains tests