fix(l1): retry head fetch during sync #5604
Open
+65
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Oppen
reviewed
Dec 11, 2025
crates/networking/p2p/sync.rs
Outdated
| return Ok(()); | ||
| } | ||
| attempts += 1; | ||
| tokio::time::sleep(Duration::from_millis(200)).await; |
Contributor
There was a problem hiding this comment.
This is a lot of time to sleep. Maybe you should try an exponential backoff?
Oppen
reviewed
Dec 11, 2025
crates/networking/p2p/sync.rs
Outdated
| return Ok(()); | ||
| } | ||
| attempts += 1; | ||
| tokio::time::sleep(Duration::from_millis(200)).await; |
MegaRedHand
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently one of the hive tests is failing, with the log
Sync failed to find target block header, aborting.This is because currently we only retry 5 times and (for low-latency scenarios like a testnet) without delay between the attempts. If the header isn't immediately available, we abort.
Description
This solves the problem by introducing a retry-with-delay logic.
The currently existing logic in
request_block_headers_from_hashis removed since it now becomes redundant.Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.