-
Notifications
You must be signed in to change notification settings - Fork 138
chore(l1): bump fixtures version to v5.4.0 #5605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the execution-spec-tests fixtures from v5.3.0 to v5.4.0, following the recent release of version 5.4.0.
- Updated fixture URLs in both state and blockchain test directories to point to v5.4.0
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tooling/ef_tests/state/.fixtures_url | Updated fixtures URL from v5.3.0 to v5.4.0 |
| tooling/ef_tests/blockchain/.fixtures_url | Updated fixtures URL from v5.3.0 to v5.4.0 |
The changes are straightforward and consistent across both files. Both fixture URL files have been updated to reference the same v5.4.0 release. No issues were identified in the changed code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EF Tests Comparison
|
**Motivation** We don't currently validate that header and body match when importing blocks. This could cause unclear errors when working on invalid data, so we should check that. Also, some hive tests were failing because of that. **Description** This PR adds to `import_blocks` and `import_blocks_bench` a check that header and body match. Closes #5601 Related to #5605
|
This is probably just missing the fix from #5608 |
Lines of code reportTotal lines added: Detailed view |
792dd3c to
a51d505
Compare
Motivation
5 days ago v5.4.0 of execution-spec-tests was released.
Description
This PR updates our tests to use that release.
Related to #5601
TODO: revert 792dd3c once #5608 is merged