Skip to content

Conversation

@MegaRedHand
Copy link
Collaborator

@MegaRedHand MegaRedHand commented Dec 11, 2025

Motivation

5 days ago v5.4.0 of execution-spec-tests was released.

Description

This PR updates our tests to use that release.

Related to #5601

TODO: revert 792dd3c once #5608 is merged

Copilot AI review requested due to automatic review settings December 11, 2025 18:21
@MegaRedHand MegaRedHand requested a review from a team as a code owner December 11, 2025 18:21
@github-actions github-actions bot added the L1 Ethereum client label Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the execution-spec-tests fixtures from v5.3.0 to v5.4.0, following the recent release of version 5.4.0.

  • Updated fixture URLs in both state and blockchain test directories to point to v5.4.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tooling/ef_tests/state/.fixtures_url Updated fixtures URL from v5.3.0 to v5.4.0
tooling/ef_tests/blockchain/.fixtures_url Updated fixtures URL from v5.3.0 to v5.4.0

The changes are straightforward and consistent across both files. Both fixture URL files have been updated to reference the same v5.4.0 release. No issues were identified in the changed code.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

EF Tests Comparison

Test Name MAIN PR DIFF
Summary: 70821/70821 (100.00%) 72876/72876 (100.00%) ➖️ 2055
Osaka: 19093/19093 (100.00%) 19517/19517 (100.00%) ➖️ 424
Prague: 21092/21092 (100.00%) 21502/21502 (100.00%) ➖️ 410
Cancun: 22644/22644 (100.00%) 23054/23054 (100.00%) ➖️ 410
Shanghai: 4164/4164 (100.00%) 4571/4571 (100.00%) ➖️ 407
Paris: 3828/3828 (100.00%) 4232/4232 (100.00%) ➖️ 404

@MegaRedHand MegaRedHand moved this to In Progress in ethrex_l1 Dec 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2025
**Motivation**

We don't currently validate that header and body match when importing
blocks. This could cause unclear errors when working on invalid data, so
we should check that. Also, some hive tests were failing because of
that.

**Description**

This PR adds to `import_blocks` and `import_blocks_bench` a check that
header and body match.

Closes #5601

Related to #5605
@MegaRedHand
Copy link
Collaborator Author

This is probably just missing the fix from #5608

@github-actions
Copy link

Lines of code report

Total lines added: 8
Total lines removed: 0
Total lines changed: 8

Detailed view
+------------------------------------------------------------+-------+------+
| File                                                       | Lines | Diff |
+------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/guest_program/src/execution.rs | 515   | +8   |
+------------------------------------------------------------+-------+------+

@MegaRedHand MegaRedHand force-pushed the bump-eels-fixtures-v5.4.0 branch from 792dd3c to a51d505 Compare December 18, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants