test(l1): add FCU test for StateNotReachable case #5628
Conversation
Add a unit test that verifies apply_fork_choice returns StateNotReachable when attempting to fork choice to a block whose state root is not available in the trie. Closes lambdaclass#5603
crates/blockchain/smoke_test.rs
Outdated
| let result = apply_fork_choice(&store, block_hash, genesis_hash, genesis_hash).await; | ||
|
|
||
| assert!( | ||
| matches!(result, Err(InvalidForkChoice::StateNotReachable)), | ||
| "Expected StateNotReachable, got {:?}", | ||
| result | ||
| ); |
There was a problem hiding this comment.
This case isn't that useful. On normal operation, if we have the state for a block, and we receive a child, we'll only insert the header into the database if we executed the block (we have the state), so this can't happen.
The issue refers to cases where we have a reorg, and the nearest chain link is beyond our pruning range (128 blocks, currently).
There was a problem hiding this comment.
understood, rewrote the test to cover the actual reorg scenario you described. builds 130 blocks on canonical, forks early, then simulates the pruning by clearing the trie cache before attempting the reorg.
Had to add a test helper (clear_trie_cache_for_testing) to Store since the InMemory backend threshold is 10k and won't prune naturally in tests.
The previous test created an artificial scenario (fake state_root) that can't occur in production. The new test simulates the actual case: - Build canonical chain beyond 128-block pruning threshold - Create fork early in chain - Common ancestor's state gets pruned - Reorg to fork fails with StateNotReachable Added clear_trie_cache_for_testing() helper to Store.
Peponks9
left a comment
Peponks9
left a comment
There was a problem hiding this comment.
hey @madisoncarter1234 looks like the lint check failing causes the other two tests to fail.
Peponks9
left a comment
Peponks9
left a comment
There was a problem hiding this comment.
is this being blocked by another task?
just waiting on approvals, ready for review |
3 participants
Summary
StateNotReachableerror inapply_fork_choicecovering the real-world pruning scenarioStateNotReachableclear_trie_cache_for_testing()helper to Store for simulating pruning in tests (InMemory backend uses 10k threshold)Test plan
cargo test -p ethrex-blockchain test_state_not_reachable_on_reorg_beyond_pruning_rangeCloses #5603