feat(l1): discv5 #5655
Merged
feat(l1): discv5 #5655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #5574 and #5575. Co-authored-by: Esteban Dimitroff Hodi <[email protected]>
**Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #issue_number
**Motivation** I saw current new_nonce impl allocated a vector when it can just return a fixed size array. **Description** Removes the needless vec **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync.
**Motivation** In order to start merging discv5 code into main, to avoid having a huge PR at the end of the development, we should create a feature flag disabled by default. Closes #5639
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync.
ElFantasma
requested review from
a team,
ManuelBilbao,
avilagaston9 and
ilitteri
as code owners
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
reviewed
Dec 18, 2025
Oppen
approved these changes
Dec 18, 2025
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
Left a few comments but given it won't be enabled until it's ready, I think it's mostly safe to approve.
If you're gonna apply anything I suggested, the most important right now is the feature name suggestion IMO.
… tests (#5673) **Motivation** Adds a Session struct and related functions to the discv5 module, this represents a session established from a handshake. This PR does not implement the handshake protocol, but it lays a path to doing so easily. This is based on reading https://github.com/ethereum/devp2p/blob/master/discv5/discv5-theory.md#sessions This allows us to add the remaining test vectors related to cryptography, which is done now. Also renamed the PacketDecodeErr to PacketCodecError, since the error was also used when encoding and for other things. Fixed nonce generation to be secure according to the spec
MegaRedHand
approved these changes
Dec 18, 2025
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct Session { | ||
| pub keys: SessionKeys, | ||
| pub role: SessionRole, |
Collaborator
There was a problem hiding this comment.
Does this need to be kept? I think the role can be removed if we switch the keys in one of the two cases (maybe rename the keys to local and remote too).
Contributor
Author
There was a problem hiding this comment.
I will change it in a future PR
ManuelBilbao
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ethereum nodes are expected to run
discv5for early 2026.Description
On one hand, this is work in progress, but in the other we don't want to have a huge PR at the end of development. So we plan to start merging
discv5work into main, but behind a feature flag so nothing is compiled or run, except for development. The flag is already present in this commit, so we should be clear to merge.Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.Closes #4491