Repository navigation
fix(index): reject invalid boolean values in CREATE INDEX WITH - #258
Merged
Xuanwo merged 2 commits intoOct 2, 2026
Merged
Conversation
The string WITH parser coerced train/replace/retrain loosely: train=ture (a typo) or a quoted train='false' failed the bare false/0 check and silently kept the default, so training was skipped or forced with no error. Route the three options through a shared helper accepting the same spellings the DuckDB-native path already enforces in ValueToBoolOrThrow (true/1, false/0, else reject), making the two paths consistent.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
lance-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string WITH parser for
CREATE INDEX ... USING <type> WITH (...)coerced train/replace/retrain loosely:train=ture(a typo) or a quotedtrain='false'did not match the barefalse/0check and silently kept the default, so training was skipped or forced with no error. The DuckDB-native binding path already rejects such values viaValueToBoolOrThrow.This routes the three boolean options through a shared helper accepting the same spellings (
true/1,false/0, else reject), so the two paths agree.Testing
GEN=ninja make test_release— index_ddl.test now rejectstrain=tureandreplace=maybe, both of which silently succeeded before.