Skip to content

chore(deps): upgrade OpenDAL to 0.58#7823

Open
Xuanwo wants to merge 2 commits into
mainfrom
xuanwo/upgrade-opendal-0.58
Open

chore(deps): upgrade OpenDAL to 0.58#7823
Xuanwo wants to merge 2 commits into
mainfrom
xuanwo/upgrade-opendal-0.58

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

OpenDAL 0.58 introduces a finished-operator construction API and removes native capability accessors. Keeping Lance on the current OpenDAL release avoids carrying an outdated storage integration while preserving the behavior of all OpenDAL-backed object store providers.

No user-facing behavior change is intended. The root, Python, and Java dependency graphs remain aligned on the same OpenDAL release.

@github-actions github-actions Bot added A-python Python bindings A-java Java bindings + JNI A-deps Dependency updates A-encoding Encoding, IO, file reader/writer chore labels Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

OpenDAL and object_store_opendal are upgraded from 0.57 to 0.58. Provider implementations and tests now use operators directly without calling .finish(), and Azure capability checks use .capability().

Changes

OpenDAL 0.58 migration

Layer / File(s) Summary
Provider operator construction
Cargo.toml, rust/lance-io/src/object_store/providers/*
OpenDAL dependencies are upgraded, and provider operator creation removes .finish() while preserving mapped construction errors.
Operator consumers and validation
rust/lance-io/src/object_store/dynamic_opendal.rs, rust/lance-io/src/object_store/providers/azure.rs, rust/lance-io/tests/goosefs_integration.rs
Tests pass direct operators to OpendalStore, GooseFS integration returns the direct operator, and Azure tests use .capability().

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jackye1995, wjones127

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: upgrading OpenDAL to 0.58.
Description check ✅ Passed The description is directly related to the OpenDAL upgrade and its API impact.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch xuanwo/upgrade-opendal-0.58

Comment @coderabbitai help to get the list of available commands.

@Xuanwo
Xuanwo marked this pull request as ready for review July 16, 2026 15:15

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Dependency updates A-encoding Encoding, IO, file reader/writer A-java Java bindings + JNI A-python Python bindings chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant