Analysis clean up... again#85
Draft
BrendanKKrueger wants to merge 12 commits into
Draft
Conversation
…ch deeper than I thought. That suggested that changes may need to be much more incremental than I thought, working towards a goal.
…nvalues, but this does remove the need for the old calculations. Eventually (once I figure out the math error that's gotta be lurking somewhere), I can get rid of eigendecomposition_analysis because it's been replaced by the new 'flexible API' method.
The error_analysis function signature changed to accept OperatorRepresentation objects (exact_op, approx_op) instead of raw matrices (exact_matrix, unitary_matrix, exact_eigendecomp, approx_eigendecomp). Changes: - Updated all test_error_analysis.py tests to create OperatorRepresentation objects - Added helper functions to create test OperatorRepresentation objects - Marked matrix-free operator tests as skipped (Phase 3 functionality not yet implemented) - All 16 error_analysis tests now pass (2 skipped) Test results after this commit: - common tests: 190/190 passed (100%) - analysis tests: 266/285 passed (93.3%), 17 failed, 2 skipped Remaining 17 failures require fixes to implementation code (not test code): - test_analysis_integration.py: 7 failures due to debugging code in analysis.py - test_operators.py: 6 failures in OperatorRepresentation energy shift logic - test_time_evolution_algorithms.py: 4 resource estimation test failures These remaining failures will be resolved by fixing analysis.py and operators.py implementation code, which is still under development.
…ut later down to the bottom of the analysis routine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.