fix(bus): execute callbacks for empty batches #58165
Closed
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Bus::batch([]) is called with an empty array, the then() and finally() callbacks were not being executed. This was counterintuitive as batches with zero jobs should logically complete immediately and trigger their completion callbacks. This change detects when no jobs are added to a batch and immediately marks it as finished, executing the registered then() and finally() callbacks. Fixes laravel#58163
Member
|
Slight breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Bus::batch([]) is called with an empty array, the then() and finally() callbacks were not being executed. This was counterintuitive as batches with zero jobs should logically complete immediately and trigger their completion callbacks.
This change detects when no jobs are added to a batch and immediately marks it as finished, executing the registered then() and finally() callbacks.
Fixes #58163