Hover and annotation colour - #104
Merged
Merged
Conversation
The annotation modal pre-filled its colour picker with the clicked signal's line colour, so a mark came out in the one colour it cannot be read against. It now always opens on the palette default. The pre-fill also only ever fired for a signal given an explicit colour in database_options — Plotly assigns colorway colours at render time, so an uncoloured signal's trace has none — making the behaviour inconsistent between signals for no reason visible to a user. Drops the whole path rather than just the read: `line_color` leaves the trace_map store (with the defensive try/except that produced it) and `suggested_color` leaves modal_data, so nothing dead crosses the store. Annotations already in annotations.json keep their colour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
UNIFIED_HOVER gated two settings with different preconditions: a time
format needs a time axis, a unified panel needs traces worth reading
together at one x. PSD has the second without the first, so the flag
could not express it.
The time format moves to TIME_AXIS and UNIFIED_HOVER keeps the panel
style, which lets psd drop its UNIFIED_HOVER = False. A PSD's rows lose
the frequency the panel header already carries, and PlotOptions grows
x_axis_hover_format so that header reads 12.2 rather than a raw bin
centre — set by a plot type whose x is not time, unlike the user's
time format.
Spectrogram gains the user's hover time format as a result: its x is
time and its heatmap hover printed a raw %{x}, ignoring the setting.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.