Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk due to CI workflow changes that assume AWS roles and fetch secrets, which can affect pipeline security and stability. App/runtime changes are minimal and limited to reading an env-provided flag key.
Overview
Adds a new
run-exampleGitHub Actions job that builds the React client-only example, pulls required SDK/flag keys from AWS SSM via OIDC, and runs Playwright e2e tests; the workflow also gains a nightlyscheduletrigger and skips the existing matrix build on scheduled runs.Introduces Playwright test infrastructure for the example app (config +
verify.spec.ts), wires atestscript and@playwright/testdependency, ignorestest-results/, and updates the app to read the feature flag key fromimport.meta.env.LAUNCHDARKLY_FLAG_KEY(with a fallback).Written by Cursor Bugbot for commit 8c5c607. This will update automatically on new commits. Configure here.