Skip to content

test: add example app verification#1162

Open
joker23 wants to merge 1 commit intomainfrom
skz/sdk-1960/react-example-test
Open

test: add example app verification#1162
joker23 wants to merge 1 commit intomainfrom
skz/sdk-1960/react-example-test

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Mar 7, 2026

Note

Medium Risk
Moderate risk due to CI workflow changes that assume AWS roles and fetch secrets, which can affect pipeline security and stability. App/runtime changes are minimal and limited to reading an env-provided flag key.

Overview
Adds a new run-example GitHub Actions job that builds the React client-only example, pulls required SDK/flag keys from AWS SSM via OIDC, and runs Playwright e2e tests; the workflow also gains a nightly schedule trigger and skips the existing matrix build on scheduled runs.

Introduces Playwright test infrastructure for the example app (config + verify.spec.ts), wires a test script and @playwright/test dependency, ignores test-results/, and updates the app to read the feature flag key from import.meta.env.LAUNCHDARKLY_FLAG_KEY (with a fallback).

Written by Cursor Bugbot for commit 8c5c607. This will update automatically on new commits. Configure here.


Open with Devin

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25566 bytes
Compressed size limit: 26000
Uncompressed size: 125383 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172130 bytes
Compressed size limit: 200000
Uncompressed size: 800872 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 24212 bytes
Compressed size limit: 25000
Uncompressed size: 83755 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 21281 bytes
Compressed size limit: 24000
Uncompressed size: 110213 bytes

@joker23
Copy link
Contributor Author

joker23 commented Mar 7, 2026

@cursor review

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 marked this pull request as ready for review March 7, 2026 00:19
@joker23 joker23 requested a review from a team as a code owner March 7, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant