fix: update uuid from ^8.0.0 to ^11.1.1#145
Closed
kinyoklion wants to merge 3 commits into
Closed
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
uuid v12+ dropped CommonJS support, so v11 is the latest compatible version for this CommonJS project. No API changes were required as the v1 export remains stable. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Remove the uuid package dependency and replace it with an inline UUID v4 implementation adapted from js-core's browser SDK polyfill. This avoids the CommonJS compatibility issue with uuid v12+ while also eliminating the external dependency entirely. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A
Describe the solution you've provided
Updates the
uuiddependency from^8.0.0to^11.1.1. Thev1export used across the codebase (diagnosticEvents.js,AnonymousContextProcessor.js,EventSender.js) remains stable with no API changes required.uuid v12+ dropped CommonJS support entirely, so v11 is the latest compatible major version for this CommonJS project. No code changes were needed beyond the version bump.
Describe alternatives you've considered
Additional context
Link to Devin session: https://app.devin.ai/sessions/63cc8da489324f20b17db43d0d296dea
Requested by: @kinyoklion