fix(deps): bump golang.org/x/crypto to v0.55.0 for CVE-2026-56854 - #848
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
Sep 1, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
golang.org/x/cryptofrom v0.53.0 to v0.55.0 to clear HIGH CVE-2026-56854, newly flagged by Docker Scout against v8 base source (currently failing on PRs #841–#847).golang.org/x/cryptov0.53.0 → v0.55.0 (fix version for CVE-2026-56854, affected< 0.55.0)golang.org/x/*bumps only:netv0.56.0 → v0.57.0,syncv0.21.0 → v0.22.0,sysv0.46.0 → v0.47.0,textv0.39.0 → v0.41.0go.modalready declaresgo 1.25.10Requirements
Implementation details and validation
Change mechanism
Applied with Go tooling only:
git diff --statis limited togo.mod(10 lines) andgo.sum(28 lines). Thex/net,x/sync,x/sys, andx/textbumps are the minimum-version-selection consequences of thex/cryptorequirement graph, not discretionary upgrades.Validation
go build ./...— cleanmake lint(golangci-lint v2.13.1) — 0 issuesmake test— all packages pass except one timing-sensitive assertion ininternal/metrics,TestStreamDurationIsNotAffectedByActivityCounts("stream time should be approximately 10ms"), which is load-dependent: re-running it with-count=5passes both on this branch and on the unmodifiedv8base commit, so it is not caused by this change.Scope notes
This is a newly detected vulnerability in dependency source that was already present on the unchanged
v8base — not a regression introduced by PRs #841–#847, and not a flaky scanner result. Merging this tov8should clear the Docker Scout check for those PRs once they pick up the base.Alternatives considered
Suppressing or downgrading the Docker Scout policy, or pinning only the indirect graph — both rejected: the CVE has an upstream fixed version that the current Go toolchain requirement already supports, so the direct upgrade is the correct remediation.
Link to Devin session: https://app.devin.ai/sessions/8343658d95954c098ee39e4a10b3883f
Open in Devin Desktop: https://app.devin.ai/desktop/session/8343658d95954c098ee39e4a10b3883f?variant=devin
Requested by: @kparkinson-ld
Note
Overview
Dependency-only security remediation with no application source changes—only
go.modandgo.sumare updated.The primary change bumps
golang.org/x/cryptofrom v0.53.0 to v0.55.0 to address CVE-2026-56854 (Docker Scout / HIGH), which affects versions below 0.55.0.Go’s module resolution also updates the minimum compatible
golang.org/x/*versions:syncv0.21.0 → v0.22.0 (direct), and indirectnet,sys, andtextto v0.57.0, v0.47.0, and v0.41.0 respectively, with matching checksum entries ingo.sum.Reviewed by Cursor Bugbot for commit 9ca42d6. Bugbot is set up for automated code reviews on this repo. Configure here.