perf: import MUI icons by path instead of the barrel - #93
Open
saurabhraghuvanshii wants to merge 1 commit into
Open
saurabhraghuvanshii wants to merge 1 commit into
saurabhraghuvanshii wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ESLint configuration now rejects ChangesMUI icon import migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The PR changes only icon import paths and lint enforcement. Tests pass, with no identified user-facing or operational regression. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Seven components imported icons from the `@mui/icons-material` barrel. The
rollup build keeps dependencies external, so `dist/index.js` shipped a
`require('@mui/icons-material')` for 11 icons, and every consumer's bundler
then had to resolve and parse the ~10,800 modules that barrel re-exports.
Import each icon by path and add a `no-restricted-imports` lint rule so the
barrel cannot come back. The built bundle now has zero barrel requires and
11 deep ones. All 236 tests pass; the 8 remaining lint errors are
pre-existing class-field parsing errors, identical on master.
Signed-off-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
saurabhraghuvanshii
force-pushed
the
perf/deep-mui-icon-imports
branch
from
September 13, 2026 22:04
2a2f3e5 to
fb83a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven components imported icons from the
@mui/icons-materialbarrel. The rollup build keeps dependencies external, sodist/index.jsshipped arequire('@mui/icons-material')for 11 icons, and every consumer's bundler then had to resolve and parse the ~10,800 modules that barrel re-exports.Import each icon by path and add a
no-restricted-importslint rule so the barrel cannot come back. The built bundle now has zero barrel requires and 11 deep ones. All 236 tests pass; the 8 remaining lint errors are pre-existing class-field parsing errors, identical on master.Notes for Reviewers
This PR fixes #
Signed commits
Summary by CodeRabbit
Refactor
Chores