Open
Conversation
pratikfegade
requested review from
govereau,
jiancheng-aws,
joonwonc,
jtristan,
ppotapov-aws,
seanmcl and
waahm7
as code owners
govereau
approved these changes
Nov 10, 2025
waahm7
requested changes
Nov 10, 2025
| @@ -676,7 +676,6 @@ def builtinEnv : List (Name × Term) := Id.run do | |||
| let fn := .builtin name none | |||
Collaborator
There was a problem hiding this comment.
Let's not merge this change until we are 100% sure that it's not breaking anything in NKI. One example of breaking change is that neuron_isa.py doesn't have nisa.dma_compute. Please coordinate with Yongwei Yuan.
Collaborator
Author
There was a problem hiding this comment.
Yes. this change is blocked until I can iron out all issues on the NeuronKernelInterface and KaenaCompiler end of things.
Collaborator
There was a problem hiding this comment.
The change will break NKI; see NKIFE-506. Meanwhile, I am going through ISA.lean and neuron_isa.py to make sure APIs are consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.