feat: Update run phase log output UI to address long page scrolling - #979
Open
mlanth wants to merge 3 commits into
Open
feat: Update run phase log output UI to address long page scrolling#979mlanth wants to merge 3 commits into
mlanth wants to merge 3 commits into
Conversation
… to jump to ends of the log or expand it to its previous behavior. Add new route to download raw logs.
…atus rather than a fixed message count, since notifications are published per run event, not per status transition.
…. A cancel arriving before the process was registered was silently dropped, hanging the process. Writes from the stdout and stderr copy goroutines also raced on the shared output.
Contributor
Author
|
Fixes for tests are unrelated to UI change as they seem to also intermittently appear directly against master however it seems this PR was unlucky to run into them. Can split them out if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some of the concerns of #967.
Changes:
Added toolbar above log output providing actions to jump to ends of the log or expand it, reverting to previous full body scroll.
New route to download raw phase logs.