Skip to content

fix: correct inverted segment condition logic in docs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voj-tech-j merged 2 commits into from
Aug 15, 2026
Merged

fix: correct inverted segment condition logic in docs #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2446fd7
fix: correct inverted segment condition logic in docs
voj-tech-j Aug 15, 2026
03f97f0
chore: release 1.5.1
voj-tech-j Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.5.1] - 2026-08-15

### Fixed

- Corrected the segment condition documentation on `SegmentConditionGroup` and `SegmentConditionsInput`: conditions **within a group** are joined by `OR`, and **groups** are joined by `AND` — i.e. `(A OR B) AND (C OR D)`. The previous Javadoc stated the inverse. No behaviour change — the API has always evaluated segments this way, and no code paths were touched. Worth a read if you built a segment against the old description, since it may target a wider or narrower audience than you intended.

## [1.5.0] - 2026-08-14

Covers the reworked bulk contact import (TPL-2105) and the duplicate-create fix. Everything here is additive — code written against 1.4.0 keeps compiling and sends the exact same payloads.
Expand Down Expand Up @@ -180,6 +186,7 @@ Initial release.
- Bearer token auth, Gson-based JSON serialization
- Structured exceptions: `LettrException`, `LettrApiException`, `LettrValidationException`

[1.5.1]: https://github.com/lettr/lettr-java/compare/v1.5.0...v1.5.1
[1.5.0]: https://github.com/lettr/lettr-java/compare/v1.4.0...v1.5.0
[1.4.0]: https://github.com/lettr/lettr-java/compare/v1.3.0...v1.4.0
[1.1.0]: https://github.com/lettr/lettr-java/compare/v1.0.0...v1.1.0
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GROUP=com.lettr
VERSION=1.5.0
VERSION=1.5.1
POM_ARTIFACT_ID=lettr-java
POM_NAME=Lettr Java SDK
POM_DESCRIPTION=Java SDK for the Lettr Email API
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/lettr/services/audience/segments/model/SegmentConditionGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import java.util.List;

/**
* A group of conditions joined by AND. Multiple groups in a segment are joined by OR.
* A group of conditions joined by OR. Multiple groups in a segment are joined by AND.
*/
public class SegmentConditionGroup {

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/lettr/services/audience/segments/model/SegmentConditionsInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

/**
* Wrapper used as the {@code conditions} field on segment create/update requests.
* The top-level groups are joined by OR; conditions within each group are joined by AND.
* The top-level groups are joined by AND; conditions within each group are joined by OR.
*/
public class SegmentConditionsInput {

Expand Down
Loading