Store flow logs as JSON, matching info/metrics - #157
Open
milan-zededa wants to merge 1 commit into
Open
Conversation
flowLogProcess still wrote raw protobuf FlowMessage bytes. With the file driver, multiple messages accumulate in the same file, and concatenated protobuf messages are not self-delimiting -- worse, FlowMessage's DevId field (number 1, wire type 2) has tag byte 0x0A, the same byte deviceDataGet appends as a chunk separator when serving GET requests, so naive newline-splitting on the client side would routinely split messages mid-field. Convert to JSON at write time instead, the same treatment applied to info/metrics in 3af1f41. Signed-off-by: Milan Lenco <milan@zededa.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flowLogProcessstill wrote raw protobufFlowMessagebytes. With the file driver, multiple messages accumulate in the same file, and concatenated protobuf messages are not self-delimiting -- worse,FlowMessage'sDevIdfield (number 1, wire type 2) has tag byte0x0A, the same bytedeviceDataGetappends as a chunk separator when serving GET requests, so naive newline-splitting on the client side would routinely split messages mid-field.Convert to JSON at write time instead, the same treatment applied to info/metrics in 3af1f41.