Bump eve-api so newer fields are not dropped - #159
Merged
Merged
Conversation
Adam's copy of the API was four months behind, so every field added to it since was dropped on the way through: the admin stream re-serializes what a device sent using adam's own descriptor, and protojson discards what that descriptor does not carry. Anything reading adam saw those fields as unset however correctly the device reported them. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
milan-zededa
approved these changes
Aug 29, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adam's copy of the API was four months behind, so every field added to eve-api
since then was dropped on the way through. The admin API re-serializes what a
device sent using adam's own descriptor, and protojson discards what that
descriptor does not carry, so anything reading adam saw those fields as unset
however correctly the device had reported them.
The case that surfaced it is the deferred queue telemetry from eve-api#154: a
device reporting
deviceMetric.deferred_queueand the new per-URL counterscame back with them empty, which reads as an EVE bug rather than a controller
one.
The bump is go.mod/go.sum only — no code changes were needed.
go build ./...,go vet ./...and the full test suite pass.Verified with an A/B on the one variable: the same EVE image and the same
evetest assertions see the new fields as nil against the released adam image
and fully populated against this change.