[17.0-stable] pkg/debug: Do not populate productURL and logo fields in the device model - #6263
Merged
Merged
Conversation
The productURL field from the device model expects an URL that points to a product page of the device. Such information is not provided through SMBIOS table by default, and usually unlikely to be present. Given some controllers might impose a valid URL, it doesn't make sense to populate this field with the device model, so better to let it empty so it can be populated later with a valid URL without break the device model for the controller. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit 22c22df)
The logo_back and logo_front fields from the device model are populated with default file names by the spec.sh script. However, the upload of the model to the controller will fail if these files don't exist. This commit clears both logo fields, so it makes the upload to controller less error prone. The fields can still be manually populated by the user with the proper image files that do exist in the system. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit 9c8d4ff)
Update eve-debug image hash to the latest version. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 17.0-stable #6263 +/- ##
===============================================
+ Coverage 20.61% 21.02% +0.40%
===============================================
Files 506 516 +10
Lines 92880 94578 +1698
===============================================
+ Hits 19148 19882 +734
- Misses 72136 72921 +785
- Partials 1596 1775 +179 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6234
How to test and validate this PR
Run
spec.sh, theproductURL,logo_frontandlogo_back fieldsof the output model must be empty.Changelog notes
spec.sh: Do not populateproductURLandlogofields when generating device model, so it can be populated later by the user with a valid URL and file paths.Checklist
check them.