Parse ISO8601 format strings as datetimes#78
Merged
brycekbargar merged 2 commits intolibrary-data-platform:mainfrom Apr 27, 2026
Merged
Parse ISO8601 format strings as datetimes#78brycekbargar merged 2 commits intolibrary-data-platform:mainfrom
brycekbargar merged 2 commits intolibrary-data-platform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FOLIO dates and times are usually RFC3339. During the initial re-implementation I didn't quite understand what that meant and hadn't dug any further because there was a bunch of other changes going into the release. In #77 it was determined that dates from FOLIO are commonly in the less restrictive ISO8601 format. After learning more about RFC3339 and ISO8601 I created a regex which I believe handles all the datetimes that FOLIO can return with two exceptions.
Many test cases for both the positive and negative case have been added to verify/document the supported conversion.
There was a latent fault in the sql for datetimes. The returned column was named
is_uuidinstead ofis_datetime. Because the columns are read into python by position and not name this had not caused an error.