Implement MigratableKVStore for VssStore#469
Closed
G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Implement MigratableKVStore for VssStore#469G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Contributor
G8XSU
commented
Feb 12, 2025
G8XSU
commented
- Implement MigratableKVStore for VssStore
enigbe
reviewed
Mar 13, 2025
Contributor
enigbe
left a comment
enigbe
left a comment
There was a problem hiding this comment.
@G8XSU I have reviewed the implementation done here and it LGTM. I did some local testing to migrate from VssStore to FilesystemStore (also impl MigratableKVStore) and it works as it should.
Unrelated to this PR, but I noticed that the unit tests in src/io/vss_store require vss-server to be running at TEST_VSS_BASE_URL. Should we mock vss-server responses to keep them as unit tests, or should we move them to integration tests instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.