Recalculate listeners' best block heights on each retry#471
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Feb 13, 2025
Merged
Recalculate listeners' best block heights on each retry#471tnull merged 1 commit intolightningdevkit:mainfrom
tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
Previously, we would calculate each listener's best block height outside of the `loop`, which will have us retrying `init::synchronize_listeners` with stale data, potentially leading to panicking as we might try to connect blocks from the original height to listeners that might have been advanced by the previous itertation of the `loop` before hitting an error. Here, we mitigate this by simply retrieving the current best block height for each listener at the start of each iteration.
jkczyz
approved these changes
Feb 13, 2025
Comment on lines
+296
to
+306
| let mut chain_listeners = vec![ | ||
| ( | ||
| onchain_wallet_best_block_hash, | ||
| &**onchain_wallet as &(dyn Listen + Send + Sync), | ||
| ), | ||
| ( | ||
| channel_manager_best_block_hash, | ||
| &*channel_manager as &(dyn Listen + Send + Sync), | ||
| ), | ||
| (sweeper_best_block_hash, &*output_sweeper as &(dyn Listen + Send + Sync)), | ||
| ]; |
Contributor
There was a problem hiding this comment.
Discussed offline that making current_best_block a method on Listen would be useful. It simplifies the API and would avoid needing to allocate a Vec on each iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would calculate each listener's best block height outside of the
loop, which will have us retryinginit::synchronize_listenerswith stale data, potentially leading to panicking as we might try to connect blocks from the original height to listeners that might have been advanced by the previous itertation of theloopbefore hitting an error. Here, we mitigate this by simply retrieving the current best block height for each listener at the start of each iteration.