Support isEqualNode
#1246
Merged
Support isEqualNode
#1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Dec 5, 2025
nikneym
force-pushed
the
nikneym/is-equal-node
branch
from
4280906 to
8731471
Compare
karlseguin
reviewed
Dec 8, 2025
Collaborator
|
Tests? |
nikneym
force-pushed
the
nikneym/is-equal-node
branch
from
8731471 to
4e23f8d
Compare
rework `isEqualNode` Splits equality logic by node types and groups comparisons nicer. prefer ancestor's`isEqualNode` `nodeType` => `getNodeType` fix attribute comparison logic Also introduces attribute counting. remove debug logging add `isEqualNode` test
nikneym
force-pushed
the
nikneym/is-equal-node
branch
from
4e23f8d to
fe89aad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bare minimum required for a specific website, I'll add support for other variants once needed.