Fix potential division by zero in cpuctUtilityStdevPrior#1156
Open
ChinChangYang wants to merge 1 commit intolightvector:masterfrom
Open
Fix potential division by zero in cpuctUtilityStdevPrior#1156ChinChangYang wants to merge 1 commit intolightvector:masterfrom
ChinChangYang wants to merge 1 commit intolightvector:masterfrom
Conversation
Change the minimum allowed value for cpuctUtilityStdevPrior from 0.0 to 1e-20 to prevent division by zero in searchexplorehelpers.cpp when computing parentUtilityStdevFactor. Fixes lightvector#831 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchexplorehelpers.cppby rejecting zero values forcpuctUtilityStdevPriorat parameter validation time0.0to1e-20insetup.cppFixes #831
Test plan
cpuctUtilityStdevPrior = 0.0is rejected with error messagecpuctUtilityStdevPrior = 1e-20is accepted (minimum boundary)cpuctUtilityStdevPrior = 10.0is accepted (maximum boundary)cpuctUtilityStdevPrior = 10.1is rejected with error message🤖 Generated with Claude Code