GHA: artifactory publish workflow: set artifactory key from secrets#2376
Merged
Conversation
…2374) ## Summary 1. Why: artifactory artifacts publishing is currently broken due to invalid credentials. 2. What: updates artifactory publish workflow to use secret token. ## Expected Behavior - publish workflow works ## Actual Behavior - publish workflow [fails](https://github.com/linkedin/cruise-control/actions/runs/26465576063/job/77924797384) ## Known Workarounds - n/a ## Additional evidence ``` $ TOKEN=**** curl -H "Authorization: Bearer $TOKEN" -X GET "https://linkedin.jfrog.io/artifactory/api/system/ping" OK ``` ## Categorization - [ ] documentation - [ ] bugfix - [ ] new feature - [ ] refactor - [x] security/CVE - [ ] other
…2375) ## Summary 1. Why: artifactory publishing is still broken, due to invalid username 2. What: username is required and must be a valid one: use ## Expected Behavior - artifactory publishing is working ## Actual Behavior - artifactory publishing is [broken](https://github.com/linkedin/cruise-control/actions/runs/26468260356) ``` Execution failed for task ':artifactoryDeploy'. > java.io.IOException: JFrog service failed. Received 401: { "errors" : [ { "status" : 401, "message" : "Unauthorized" } ] } ``` ## Steps to Reproduce https://github.com/linkedin/cruise-control/actions/runs/26468260356 ## Known Workarounds - n/a ## Categorization - [ ] documentation - [ ] bugfix - [ ] new feature - [ ] refactor - [x] security/CVE - [ ] other This PR resolves #<Replace-Me-With-The-Issue-Number-Addressed-By-This-PR> if any.
mhratson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expected Behavior
Actual Behavior