chore(ci): bump pinned toolchain to rust 1.97.0#303
Merged
Conversation
AlfioEmanueleFresta
force-pushed
the
chore/pin-ci-toolchain
branch
from
5cc98cf to
9dcdcd9
Compare
AlfioEmanueleFresta
force-pushed
the
chore/bump-ci-toolchain
branch
from
085540c to
2e19249
Compare
Now the toolchain is pinned we can move it on purpose. Bump to 1.97.0 and fix the 13 clippy warnings it brings. They are all the same one: a redundant & in a println! or write! argument. Formatting takes its arguments by reference anyway, so nothing changes at runtime. Pinning keeps CI predictable, but on its own it hides drift. Add a latest stable job that runs the same checks as the pinned build job, on master and weekly but never on pull requests, so it warns us without blocking anyone. That replaces rust-clippy.yml, which has never worked. It does not install the system dependencies, so libdbus-sys panics in its build script, the workspace never compiles and clippy lints nothing. It reported success anyway, because the step exits with the status of sarif-fmt rather than clippy, and it has been uploading empty results ever since. There are no code scanning alerts to lose.
AlfioEmanueleFresta
force-pushed
the
chore/bump-ci-toolchain
branch
from
2e19249 to
3925ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #302.
Now the toolchain is pinned we can move it on purpose. Bump to 1.97.0 and fix the 13 clippy warnings it brings. They are all the same one: a redundant & in a println! or write! argument. Formatting takes its arguments by reference anyway, so nothing changes at runtime.
Pinning keeps CI predictable, but on its own it hides drift. This adds a latest stable job running the same checks as the pinned build job. It runs on master and weekly, never on pull requests, so it warns us early without putting a red X on everyone's PR.
It also deletes rust-clippy.yml, which has never worked.