🪲 BUG-#66: Group multi-clause operands of OR/NOT in IMAP query - #75
Merged
Conversation
FernandoCelmer
commented
May 17, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 0
_group plus _is_balanced correctly preserves IMAP OR/NOT arity. Worth noting the design choices for future readers:
- Singletons stay unwrapped (
OR (SUBJECT "a") (SUBJECT "b")) — readable, still RFC 3501 valid. - Multi-clause operands get one outer paren (
OR ((SUBJECT "x") (UNSEEN)) (FROM "a@b")) — collapsed into a single search-key 'list' as the grammar requires. _is_balancedtoggles inside double quotes so a literal)inside a value wouldn't break depth counting (not exploitable today since_asciistrips non-ASCII, but defensive).
Closes #66 and #72 in one move since Query.exclude/or_/__or__/__invert__ all route through _Expr.
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_group()helper that wraps multi-clause IMAP search expressions in an outer parenthesis (single search-key group)_Expr.__or__and_Expr.__invert__now group both operands so the resultingOR/NOTarity matches the Python-level expressionQuery.exclude/Query.or_/Query.__or__/Query.__invert__since they route through_ExprCloses #66
Closes #72
Test plan
pytest tests/clients/imap/test_query.py— 16 passed