🪲 BUG-#68: Avoid mutating caller EmailMessage when adding From header - #77
Merged
Conversation
FernandoCelmer
commented
May 17, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 0
copy.deepcopy before injecting From is the minimal correct fix. Both tests are meaningful:
- Caller's message is left untouched.
- Two consecutive sends produce one
Fromheader on the wire — no header duplication on retry.
One minor non-blocking observation for the future (not required to merge): deepcopy of an EmailMessage with large attachments is O(payload size). Since the copy only happens when From is missing, this is fine in practice — but if you ever start mutating other headers, consider email.message_from_bytes(msg.as_bytes()) or a shallow rebuild instead.
Closes #68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sender.send_messagenowdeepcopy's the caller'sEmailMessagebefore injecting theFromheader when missingFrom:headers on retry and silent mutation of caller-owned objectsCloses #68
Test plan
pytest tests/clients/smtp/test_send.py— 10 passed