🪲 BUG-#69: Forward port/ssl overrides through auto-discovery factories - #79
Merged
Conversation
FernandoCelmer
commented
May 17, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 0
Correct fix. Switching port/ssl defaults to Optional[None] cleanly distinguishes "user passed default" from "user passed nothing" — the only sound way to detect intent in Python without sentinels. Forwarded through both from_address and from_env, and Email._resolve propagates the kwargs to every auto-discovery branch.
Test coverage proves both directions: override applied, omission keeps discovered values. With #74 already in, this is what unblocks Email("u@hostinger.com", "pw", port=2143, ssl=False) style configs end-to-end.
Closes #69.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Email(port=..., ssl=...)kwargs are now forwarded throughEmailFactories.from_addressandEmailFactories.from_env, so they override the values returned byresolve_imap_hostport/ssldefaults toOptionalsentinel (None) on bothEmail.__init__and the factories — distinguishes "user passed default" from "user did not pass anything"Closes #69
Test plan
pytest tests/test_email.py— 29 passed