hii: support 64-bit HiiDB addresses#12
Open
dishendradeshmukh1986 wants to merge 1 commit into
Open
Conversation
Some platforms export the HiiDB buffer above 4GB, so the physical address in the efivarfs payload does not always fit in 32 bits. Parse both the existing 32-bit payload and a 64-bit address payload so the tool can consume either firmware format. Read the exported buffer with page-sized /dev/mem mmap mappings instead of seek/read. This works for high reserved DRAM ranges where read from /dev/mem may fail. Copy the mapped data byte-by-byte to avoid faults from wider unaligned loads on memory with strict access requirements. Add parser coverage for both 32-bit and 64-bit HiiDB payloads. Signed-off-by: Dishendra Deshmukh <dishendra.deshmukh@arm.com>
Author
|
Validated on board with HiiDB exported above 4GB:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms export the HiiDB buffer above 4GB, so the physical address in the efivarfs payload does not always fit in 32 bits.
Parse both the existing 32-bit payload and a 64-bit address payload so the tool can consume either firmware format.
Read the exported buffer with page-sized /dev/mem mmap mappings instead of seek/read. This works for high reserved DRAM ranges where read from /dev/mem may fail.
Copy the mapped data byte-by-byte to avoid faults from wider unaligned loads on memory with strict access requirements.
Add parser coverage for both 32-bit and 64-bit HiiDB payloads.