Skip to content

chore: apply MegaLinter v10.1.0 standards - #17

Merged
emsearcy merged 1 commit into
mainfrom
chore/apply-megalinter-skill
Oct 14, 2026
Merged

emsearcy merged 1 commit into
mainfrom
chore/apply-megalinter-skill

Conversation

@emsearcy

@emsearcy emsearcy commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade the MegaLinter workflow and local Go-flavor image to v10.1.0 with the fleet-standard SHA and digest.
  • Re-enable blocking golangci-lint, remove stale KICS configuration, and add Go toolchain, Trivy, zizmor, Grype, and shared cspell configuration.
  • Update Go to 1.26.9, refresh dependencies, and defer the repository toolchain guidance to the lfx-megalinter skill.

Note: This PR depends on the lfx-megalinter skill as described in linuxfoundation/lfx-skills#84, which is not yet merged. The AGENTS.md toolchain-policy section here defers to that skill's Go version policy, so that skill PR should land first (or be referenced for context during review).

Issue: linuxfoundation/lfx-self-serve-ops#508

🤖 Generated with GitHub Copilot (via OpenCode)

Upgrade the workflow and local image pins, re-enable blocking Go linting, and configure the shared cspell policy. Update the Go toolchain policy and dependencies for the fleet MegaLinter standard.

Assisted-by: github-copilot:claude-opus-5.5
Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 22:36
@emsearcy
emsearcy requested a review from a team as a code owner October 14, 2026 22:36
Comment thread go.mod

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The major linter upgrade, newly blocking checks, and toolchain and dependency updates require successful CI validation before approval.

0 open findings

What changed in this PR

Updates the LFX CLI’s linting setup to MegaLinter v10.1.0 and aligns its Go toolchain and dependencies.

Changes:

  • Synchronizes CI and local MegaLinter pins and enables automatic Go toolchain downloads.
  • Restores blocking golangci-lint and adds shared spelling configuration and scanner adjustments.
  • Updates Go to 1.26.9, refreshes dependencies, and revises toolchain guidance.
File Description
Makefile Pins the local MegaLinter image and enables automatic toolchain downloads.
go.sum Updates dependency checksums.
go.mod Updates Go and dependency versions.
AGENTS.md Defers toolchain policy to shared skill guidance.
.mega-linter.yml Updates lint checks, exclusions, spelling hooks, and scanner timeout.
.github/​workflows/​mega-linter.yml Upgrades MegaLinter and enables automatic toolchain downloads.
.cspell.json Refreshes vocabulary and delegates flagged words to shared configuration.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@emsearcy
emsearcy merged commit d43fca0 into main Oct 14, 2026
9 checks passed
@emsearcy
emsearcy deleted the chore/apply-megalinter-skill branch October 14, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants